Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewriting in Progress #165

Merged
merged 14 commits into from
Aug 9, 2023
Merged

Rewriting in Progress #165

merged 14 commits into from
Aug 9, 2023

Conversation

amitojsingh
Copy link
Collaborator

@amitojsingh amitojsingh commented Jun 7, 2023 •
edited
Loading

Features in this PR

  1. rewriting the front End of the app.
  2. added caching
  3. added pagination
  4. added baniList
  5. added reader
  6. added settings part.
  7. partially bookmarks.

@amitojsingh amitojsingh marked this pull request as ready for review June 12, 2023 16:40
theamanjs
theamanjs reviewed Jun 19, 2023
View reviewed changes
src/common/store.js Outdated Show resolved Hide resolved
theamanjs
theamanjs reviewed Jun 19, 2023
View reviewed changes
src/database/db.js Outdated Show resolved Hide resolved
theamanjs
theamanjs requested changes Jul 26, 2023
View reviewed changes
src/database/db.js Show resolved Hide resolved
src/common/notifications.js Show resolved Hide resolved
src/common/notifications.js Outdated Show resolved Hide resolved
src/common/components/BaniList/BanilList.jsx Outdated Show resolved Hide resolved
src/common/components/BaniList/BanilList.jsx Outdated Show resolved Hide resolved
src/ReaderScreen/reader.jsx Show resolved Hide resolved
src/HomeScreen/HomeScreen.jsx Show resolved Hide resolved
src/HomeScreen/HomeScreen.jsx Outdated Show resolved Hide resolved
src/HomeScreen/HomeScreen.jsx Outdated Show resolved Hide resolved
src/AboutScreen/about.jsx Show resolved Hide resolved
theamanjs
theamanjs requested changes Jul 26, 2023
View reviewed changes
src/common/notifications.js Outdated Show resolved Hide resolved
src/common/notifications.js Show resolved Hide resolved
src/common/notifications.js Outdated Show resolved Hide resolved
src/common/helpers.js Outdated Show resolved Hide resolved
src/Settings/components/vishraam.jsx Outdated Show resolved Hide resolved
src/Settings/components/transliteration.jsx Outdated Show resolved Hide resolved
src/Settings/components/translation.jsx Outdated Show resolved Hide resolved
theamanjs
theamanjs requested changes Aug 4, 2023
View reviewed changes
src/ReaderScreen/components/autoScrollComponent.jsx Outdated Show resolved Hide resolved
src/ReaderScreen/components/header.js Outdated Show resolved Hide resolved
src/ReaderScreen/components/shabadItem.jsx Outdated Show resolved Hide resolved
src/ReaderScreen/reader.jsx Show resolved Hide resolved
src/ReaderScreen/utils/hooks.js Outdated Show resolved Hide resolved
theamanjs
theamanjs approved these changes Aug 8, 2023
View reviewed changes
Copy link

@theamanjs theamanjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veerji, there's just one concern from my side regarding commit standards. Please use the appropriate subject for commits. We are using fix and feat only.

Good job with the PR 🙌

@amitojsingh amitojsingh merged commit cc5c607 into Version2.0 Aug 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theamanjs theamanjs theamanjs approved these changes

Assignees
No one assigned
Labels
Mergable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amitojsingh @theamanjs