Embed data files in the binary #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we're on Go 1.16+ we can do this easily! The main advantage is it means users can build a genqlient binary and use that portably (or we could distribute one, or whatever). Plus the code is marginally simpler; the `embed` API is really quite nice. Fixes #9. Test plan: ``` make check go build . rm -rf generate # pretend we have no checkout ./genqlient ./internal/integration/genqlient.yaml ./genqlient --init # fails after generating a default config ```
benjaminjkraft
requested review from
csilvers,
dnerdy and
StevenACoffman
as code owners
csilvers
approved these changes
Mar 22, 2022
generate/config.go
Outdated
| return errorf(nil, "unable to write default genqlient.yaml: %v", err) | ||
| } | ||
| return nil | ||
| return ioutil.WriteFile(filename, defaultConfig, 0o644) |
There was a problem hiding this comment.
Does go 1.16 still require ioutil? If not you could use os.WriteFile.
There was a problem hiding this comment.
Ah, good point! Indeed 1.16 is where it's no longer required. Fixed this one, I'll do a separate PR to get rid of the rest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're on Go 1.16+ we can do this easily! The main advantage is
it means users can build a genqlient binary and use that portably (or we
could distribute one, or whatever). Plus the code is marginally simpler;
the
embedAPI is really quite nice.Fixes #9.
Test plan:
I have: