Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable input validation when use_struct_references is enabled #344

Merged

Conversation

Fazt01
Copy link
Contributor

@Fazt01 Fazt01 commented Jul 3, 2024

Fix for #342. As use_struct_references is incompatible with omitempty and pointer validation, the most simple change is to disable the validation when the use_struct_references is enabled. Note this implementation disables the validation even for types that are not influenced by use_struct_references, but still better than disabling the validation globally.

I have:

  • Written a clear PR title and description (above)
  • Signed the Khan Academy CLA
  • Added tests covering my changes, if applicable
  • Included a link to the issue fixed, if applicable
  • Included documentation, for new features
  • Added an entry to the changelog

@benjaminjkraft benjaminjkraft merged commit 2f265d2 into Khan:main Jul 3, 2024
4 checks passed
@benjaminjkraft
Copy link
Collaborator

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants