Set Expression widget's accessible field to true.
#1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todo Issue: none Test plan: todo
|
Size Change: +8 B (0%) Total Size: 815 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1001 +/- ##
==========================================
+ Coverage 63.70% 65.18% +1.47%
==========================================
Files 425 427 +2
Lines 96439 96457 +18
Branches 6298 8682 +2384
==========================================
+ Hits 61441 62877 +1436
+ Misses 34998 33580 -1418
... and 73 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
|
This is great for new exercises, but I do not believe this will fix the issue retroactively without the backfill. |
nedredmond
approved these changes
Feb 15, 2024
|
@nedredmond Yes, that's correct! I'll update the description to clarify this. |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (46d44e3) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1001 |
Merged
nishasy
added a commit
that referenced
this pull request
Feb 15, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus@19.2.1 ### Patch Changes - [#1001](#1001) [`f30c6639`](f30c663) Thanks [@nishasy](https://github.com/nishasy)! - Expression widget is marked as `accessible` internally. This will stop disabling the "requires screen or mouse" checkbox in the exercise editor for exercises that use expression widget. ## @khanacademy/perseus-editor@4.2.1 ### Patch Changes - Updated dependencies \[[`f30c6639`](f30c663)]: - @khanacademy/perseus@19.2.1
jeremywiebe
reviewed
Feb 15, 2024
| @@ -687,6 +687,7 @@ ExpressionWithDependencies.getOneCorrectAnswerFromRubric = | |||
| export default { | |||
| name: "expression", | |||
| displayName: "Expression / Equation", | |||
| accessible: true, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Now that expression widget is screenreader accessible, we want to mark it as such.
This will make it so that the exercise editor will not auto-check and auto-disable the
"requires screen or mouse" checkbox when the expression widget is used.
This will change the value of
hasViolatingWidgetsin item-controls.tsx where thecheckbox is rendered.
NOTE: This will just make it so that the checkbox won't auto-disable. It will not
update the existing values to reflect Expression now being accessible. A backfill
will still be necessary for that with our current architecture.
Issue: none
Test plan:
N/A?
Checkbox in question