-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify what versions of React the project supports #1039
Conversation
…7 or 18 ready yet)
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: +2.11 kB (0%) Total Size: 821 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1039 +/- ##
==========================================
+ Coverage 64.35% 66.38% +2.03%
==========================================
Files 427 436 +9
Lines 97258 97766 +508
Branches 6451 10128 +3677
==========================================
+ Hits 62586 64906 +2320
+ Misses 34672 32860 -1812 see 114 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (b5a8e2c) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1039 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1039 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! How do you know what the minimum version for these packages is though? Do these need to be tested?
The min version Perseus supports is mostly defined by what APIs we use. In reality, our minimum should be at what webapp and mobile are using. FEI is working on moving everything to React 18. I have #1064 open that moves Perseus to React 18, so I'm inclined to abort this PR as its changes would be very short-lived. |
Closing as #1064 will obviate the need for this PR once it lands (shortly!) |
Summary:
We received a PR that opened up the versions of React for simple-markdown a bit. This was a good idea so I've created a PR to clarify what versions of React we support.
When we complete the React v18 migration, we'll need to update these, but this puts the ranges in place so we're prepared.
Issue: "none"
Test plan: