-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecating Perseus Widgets #1046
Conversation
Size Change: -11.6 kB (-1%) Total Size: 810 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1046 +/- ##
==========================================
+ Coverage 64.72% 66.68% +1.95%
==========================================
Files 438 434 -4
Lines 97947 96259 -1688
Branches 6539 10066 +3527
==========================================
+ Hits 63393 64187 +794
+ Misses 34554 32072 -2482
... and 108 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (11bcdde) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1046 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1046 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool to see us using the replaceWidget
and replaceEditor
to remove more deprecated widgets!!
.changeset/eight-nails-accept.md
Outdated
@@ -0,0 +1,6 @@ | |||
--- | |||
"@khanacademy/perseus": minor | |||
"@khanacademy/perseus-editor": minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our version numbers don't mean much, but I would consider this very much a major change.
2cc71f4
to
cd3b326
Compare
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus@20.0.0 ### Major Changes - [#1046](#1046) [`18a2862a`](18a2862) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Deprecation of Lights-Puzzle, Simulator, Reaction Diagram, and Sequence Widgets. ## @khanacademy/perseus-editor@5.0.0 ### Major Changes - [#1046](#1046) [`18a2862a`](18a2862) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Deprecation of Lights-Puzzle, Simulator, Reaction Diagram, and Sequence Widgets. ### Patch Changes - Updated dependencies \[[`18a2862a`](18a2862)]: - @khanacademy/perseus@20.0.0
## Summary: Official deprecation and deletion of the Lights Puzzle, Simulator, Reaction Diagram, and Sequence widgets! This PR deletes the aforementioned widgets and sets them each to be replaced by the Deprecated Stand-in Widget. We moved the logic around slightly for deprecating widgets as well, in order to make deprecating a widget an easier (and safer) process. Issue: LEMS-1708 & LEMS-1799 ## Test plan: automatic tests manual tests in storybook to confirm that widgets are being replaced Author: SonicScrewdriver Reviewers: jeremywiebe, handeyeco, nixterrimus, Myranae Required Reviewers: Approved By: jeremywiebe Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage, ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Extract i18n strings (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1046
Summary:
Official deprecation and deletion of the Lights Puzzle, Simulator, Reaction Diagram, and Sequence widgets!
This PR deletes the aforementioned widgets and sets them each to be replaced by the Deprecated Stand-in Widget. We moved the logic around slightly for deprecating widgets as well, in order to make deprecating a widget an easier (and safer) process.
Issue: LEMS-1708 & LEMS-1799
Test plan:
automatic tests
manual tests in storybook to confirm that widgets are being replaced