Style movable points and segments on Mafs graphs #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See this slack thread for designs and discussion: https://khanacademy.slack.com/archives/C067UM1QAR4/p1709847469823399 Issue: LEMS-1672 Test plan: ``` yarn dev open http://localhost:5173 ``` Check the "segment" box in the dropdown at the top of the screen to switch to the Mafs version of the segment graph. You should be able to move the points and line segment with the mouse and keyboard. The hover and focus states of the points should be clearly distinct. The line segment should be highlighted blue when focused.
benchristel
requested review from
jeremywiebe,
mark-fitzgerald,
nedredmond and
nishasy
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (162f667) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1068If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1068 |
|
Size Change: +212 B (0%) Total Size: 810 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1068 +/- ##
==========================================
+ Coverage 67.29% 68.60% +1.30%
==========================================
Files 434 437 +3
Lines 96419 96512 +93
Branches 6684 10263 +3579
==========================================
+ Hits 64889 66213 +1324
+ Misses 31530 30299 -1231
... and 103 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
nishasy
approved these changes
Mar 13, 2024
| <circle className="movable-point-ring" r={8} cx={x} cy={y} /> | ||
| <circle | ||
| className="movable-point-center" | ||
| r={6} |
There was a problem hiding this comment.
Would it make sense to break out these scalar numbers into a constants file? I'm not entirely sure since it doesn't look like there are a lot of reused ones (between this file and the CSS file), but I think naming them could make it easier to figure out why the sizes are what they are in the future.
There was a problem hiding this comment.
Good call-out. Probably all of the radii should be in CSS, at least. I'll move these.
Merged
nishasy
reviewed
Mar 13, 2024
| @@ -38,11 +38,10 @@ export const MovablePoint = (props: Props) => { | |||
| } | |||
| > | |||
| <circle className="movable-point-hitbox" r={30} cx={x} cy={y} /> | |||
There was a problem hiding this comment.
Optional suggestion: Maybe also move the hitbox radius to the styles for consistency?
benchristel
pushed a commit
that referenced
this pull request
Mar 14, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus-dev-ui@1.3.0 ### Minor Changes - [#1071](#1071) [`eb637b35`](eb637b3) Thanks [@benchristel](https://github.com/benchristel)! - Add a "check answer" button to interactive graphs displayed in the dev flipbook UI ## @khanacademy/perseus@20.2.0 ### Minor Changes - [#1067](#1067) [`6196375a`](6196375) Thanks [@nishasy](https://github.com/nishasy)! - Can pass a point into `lockedFigures` into MafsGraph and a point will be displayed. - [#1074](#1074) [`a263e940`](a263e94) Thanks [@nishasy](https://github.com/nishasy)! - Add "add a locked figure" UI to interactive graph editor + adding points (mafs graphs only) ### Patch Changes - [#1068](#1068) [`881da724`](881da72) Thanks [@benchristel](https://github.com/benchristel)! - Adjust styling of the movable points and line segments on the Mafs segment graph - [#1071](#1071) [`eb637b35`](eb637b3) Thanks [@benchristel](https://github.com/benchristel)! - Add a "check answer" button to interactive graphs displayed in the dev flipbook UI - [#1073](#1073) [`ea0db7d9`](ea0db7d) Thanks [@benchristel](https://github.com/benchristel)! - Fix color of Mafs line segments ## @khanacademy/perseus-editor@5.1.0 ### Minor Changes - [#1074](#1074) [`a263e940`](a263e94) Thanks [@nishasy](https://github.com/nishasy)! - Add "add a locked figure" UI to interactive graph editor + adding points (mafs graphs only) ### Patch Changes - Updated dependencies \[[`881da724`](881da72), [`eb637b35`](eb637b3), [`6196375a`](6196375), [`a263e940`](a263e94), [`ea0db7d9`](ea0db7d)]: - @khanacademy/perseus@20.2.0 Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage, ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ⏭️ Publish npm snapshot, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Extract i18n strings (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ gerald, ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x) Pull Request URL: #1069
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See this slack thread for designs and discussion:
https://khanacademy.slack.com/archives/C067UM1QAR4/p1709847469823399
Issue: LEMS-1672
Test plan:
Check the "segment" box in the dropdown at the top of the screen to
switch to the Mafs version of the segment graph.
You should be able to move the points and line segment with the mouse
and keyboard. The hover and focus states of the points should be clearly distinct.
The line segment should be highlighted blue when focused.
Screen.Recording.2024-03-13.at.9.38.08.AM.mov