Remove unused APIOptions and types #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -169 B (-0.02%) Total Size: 839 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1301 +/- ##
==========================================
+ Coverage 68.76% 70.66% +1.89%
==========================================
Files 477 481 +4
Lines 101981 102034 +53
Branches 7250 10987 +3737
==========================================
+ Hits 70130 72100 +1970
+ Misses 31673 29934 -1739
+ Partials 178 0 -178
... and 144 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (46e7b84) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1301If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1301 |
jeremywiebe
requested review from
benchristel,
SonicScrewdriver,
nishasy,
mark-fitzgerald and
Myranae
benchristel
approved these changes
May 22, 2024
|
For posterity, I already landed and deployed a webapp change that removes usage of these options. They are optional and so webapp is fully ready for these changes in this PR whenever they are released. |
Merged
benchristel
pushed a commit
that referenced
this pull request
May 28, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus@23.0.0 ### Major Changes - [#1301](#1301) [`1ca5a12aa`](1ca5a12) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove unused/deprecated APIOptions: useDraftEditor and inModal ### Minor Changes - [#1283](#1283) [`3b85777c7`](3b85777) Thanks [@daniellewhyte](https://github.com/daniellewhyte)! - Make horizontal divider invisible to screen reader - [#1305](#1305) [`ec600a11e`](ec600a1) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Creation of the new Mafs-based Quadratic Graph for the Interactive Graph Widget - [#1310](#1310) [`e6fc912bf`](e6fc912) Thanks [@benchristel](https://github.com/benchristel)! - Upgrade to Mafs 0.18.7, which lets us draw graph axes with thicker lines. ### Patch Changes - [#1312](#1312) [`925f4ee03`](925f4ee) Thanks [@benchristel](https://github.com/benchristel)! - Fix Safari-specific bug where axis tick numbers did not appear - [#1301](#1301) [`1ca5a12aa`](1ca5a12) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove duplicate `Empty` type - Updated dependencies \[[`3b85777c7`](3b85777)]: - @khanacademy/simple-markdown@0.12.0 - @khanacademy/pure-markdown@0.3.5 ## @khanacademy/perseus-editor@6.6.0 ### Minor Changes - [#1298](#1298) [`b84e4a981`](b84e4a9) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Setting a locked line's length to 0 (equal points) will stop the exercise from saving via getSaveWarnings() - [#1305](#1305) [`ec600a11e`](ec600a1) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Creation of the new Mafs-based Quadratic Graph for the Interactive Graph Widget ### Patch Changes - [#1301](#1301) [`1ca5a12aa`](1ca5a12) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Remove duplicate `Empty` type - Updated dependencies \[[`1ca5a12aa`](1ca5a12), [`3b85777c7`](3b85777), [`ec600a11e`](ec600a1), [`925f4ee03`](925f4ee), [`1ca5a12aa`](1ca5a12), [`e6fc912bf`](e6fc912)]: - @khanacademy/perseus@23.0.0 ## @khanacademy/simple-markdown@0.12.0 ### Minor Changes - [#1283](#1283) [`3b85777c7`](3b85777) Thanks [@daniellewhyte](https://github.com/daniellewhyte)! - Make horizontal divider invisible to screen reader ## @khanacademy/pure-markdown@0.3.5 ### Patch Changes - Updated dependencies \[[`3b85777c7`](3b85777)]: - @khanacademy/simple-markdown@0.12.0 ## @khanacademy/perseus-dev-ui@1.5.9 ### Patch Changes - Updated dependencies \[[`3b85777c7`](3b85777)]: - @khanacademy/simple-markdown@0.12.0 - @khanacademy/pure-markdown@0.3.5 Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ⏭️ Publish npm snapshot, ✅ Cypress (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1308
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR removes some code/APIOptions that are completely unused today. To verify, I checked the webapp and mobile source code. I also checked and these options are not used in Perseus so even if they were set by calling applications, they do nothing.
It's time to go!
utility.d.tswhich is symlinked into each package srcinModalAPIOptionuseDraftEditorAPIOptionIssue: "none"
Test plan: