Rename StartCoordSettings to StartCoordsSettings #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nit: It should be StartCoordsSettings, not StartCoordSettings, because the field is called startCoords. Issue: none Test plan: `yarn jest`
|
Size Change: +1 B (0%) Total Size: 854 kB
ℹ️ View Unchanged
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1446 +/- ##
==========================================
+ Coverage 69.48% 70.19% +0.71%
==========================================
Files 505 508 +3
Lines 105607 105645 +38
Branches 5372 10756 +5384
==========================================
+ Hits 73379 74159 +780
+ Misses 32112 31486 -626
+ Partials 116 0 -116
... and 131 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (407d21b) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1446If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1446 |
jeremywiebe
approved these changes
Jul 24, 2024
Merged
benchristel
pushed a commit
that referenced
this pull request
Jul 29, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus@27.0.0 ### Major Changes - [#1456](#1456) [`b868801fa`](b868801) Thanks [@benchristel](https://github.com/benchristel)! - Remove unused "Show ruler" option from the interactive graph editor. The new Mafs version of the interactive graph does not implement the ruler, and we have no plans to implement it, since it can't be made accessible and isn't used in Khan Academy's existing content. - [#1450](#1450) [`2216ad012`](2216ad0) Thanks [@handeyeco](https://github.com/handeyeco)! - Remove Unit aka UnitInput widget ### Minor Changes - [#1451](#1451) [`9bc4812fc`](9bc4812) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Upgrade Mafs Dependency to v0.19.0 for Domain Restricted Functions - [#1441](#1441) [`9bc264ce1`](9bc264c) Thanks [@Myranae](https://github.com/Myranae)! - Turn off interactivity when Interactive Graph in hint mode - [#1437](#1437) [`7a448e77c`](7a448e7) Thanks [@Myranae](https://github.com/Myranae)! - Update Polygon to be filled on hover - [#1422](#1422) [`c386515ad`](c386515) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Segment and Linear System graph start coords UI ### Patch Changes - [#1448](#1448) [`84675574c`](8467557) Thanks [@nishasy](https://github.com/nishasy)! - Cleaned up the `startCoords` code in the stateful mafs graph useEffect - [#1444](#1444) [`130ab9446`](130ab94) Thanks [@nicolecomputer](https://github.com/nicolecomputer)! - Throttles point-moving performance in polygon - [#1445](#1445) [`bb1ac584b`](bb1ac58) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - useDraggable - fix to ignore keyup events (we don't want to treat keyup events as an intent to move - we have keydown for that) - Updated dependencies \[[`7e71f8e8a`](7e71f8e)]: - @khanacademy/math-input@20.0.2 ## @khanacademy/perseus-editor@11.0.0 ### Major Changes - [#1456](#1456) [`b868801fa`](b868801) Thanks [@benchristel](https://github.com/benchristel)! - Remove unused "Show ruler" option from the interactive graph editor. The new Mafs version of the interactive graph does not implement the ruler, and we have no plans to implement it, since it can't be made accessible and isn't used in Khan Academy's existing content. - [#1450](#1450) [`2216ad012`](2216ad0) Thanks [@handeyeco](https://github.com/handeyeco)! - Remove Unit aka UnitInput widget ### Minor Changes - [#1422](#1422) [`c386515ad`](c386515) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Segment and Linear System graph start coords UI ### Patch Changes - [#1446](#1446) [`4985d2d4c`](4985d2d) Thanks [@nishasy](https://github.com/nishasy)! - Rename StartCoordSettings to StartCoordsSettings - [#1448](#1448) [`84675574c`](8467557) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Refactor and clean up start coords UI implementation - Updated dependencies \[[`b868801fa`](b868801), [`84675574c`](8467557), [`7e71f8e8a`](7e71f8e), [`9bc4812fc`](9bc4812), [`130ab9446`](130ab94), [`9bc264ce1`](9bc264c), [`bb1ac584b`](bb1ac58), [`2216ad012`](2216ad0), [`7a448e77c`](7a448e7), [`c386515ad`](c386515)]: - @khanacademy/perseus@27.0.0 - @khanacademy/math-input@20.0.2 ## @khanacademy/math-input@20.0.2 ### Patch Changes - [#1454](#1454) [`7e71f8e8a`](7e71f8e) Thanks [@Myranae](https://github.com/Myranae)! - Update mathjax-renderer version ## @khanacademy/perseus-dev-ui@2.0.2 ### Patch Changes - Updated dependencies \[[`7e71f8e8a`](7e71f8e)]: - @khanacademy/math-input@20.0.2 Author: khan-actions-bot Reviewers: benchristel Required Reviewers: Approved By: benchristel Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ⏭️ Publish npm snapshot, ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Nit: It should be StartCoordsSettings, not StartCoordSettings, because
the field is called startCoords.
Issue: none
Test plan:
yarn jest