-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rm-input-number] 2 - Fix renderer-related tests #431
Conversation
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (5e5e036) and published it to npm. You Example: yarn add @khanacademy/perseus@PR431 |
Size Change: 0 B Total Size: 652 kB ℹ️ View Unchanged
|
… matched to the implementation
5202dd6
to
76fcaac
Compare
2e9838c
to
0a91529
Compare
76fcaac
to
1456267
Compare
Closing as @SonicScrewdriver and @mark-fitzgerald have implemented this. |
Summary:
This is the second PR of deleting the
input-number
widget from Perseus. In this one we fix all renderer related tests (mostly due to usinginput-number
widgets in our test data). I've left off fixing therenderer-api
tests and will address those failures in the next PR.Note that this PR contains Flow and Jest failures. I am going to fix/resolve these issues over the next few PRs so that each one is smaller and easier to review. The entire stack will only be landed once everything has been fixed and tested.
Previous PRs in stack:
Issue: LC-616
Test plan:
yarn test packages/perseus/src/__tests__/renderer_test.jsx packages/perseus/src/__tests__/server-item-renderer_test.jsx packages/perseus/src/multi-items/__tests__/multi-renderer_test.js