Remove almost all traces of Flow #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4da3e62 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
|
Size Change: -2.05 kB (0%) Total Size: 652 kB
ℹ️ View Unchanged
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (075efe1) and published it to npm. You Example: yarn add @khanacademy/perseus@PR457 |
kevinbarabash
commented
Mar 31, 2023
Comment on lines
+64
to
+66
| _selectionIsValid( | ||
| trackedSelection?: TrackedSelection | null, | ||
| ): trackedSelection is TrackedSelection { |
There was a problem hiding this comment.
This is a type predicate. This tells TypeScript to set the type of trackedSelection to TrackedSelection if the function returns true. See https://www.typescriptlang.org/docs/handbook/2/narrowing.html#using-type-predicates for more details.
jeresig
approved these changes
Apr 3, 2023
SonicScrewdriver
added a commit
that referenced
this pull request
Oct 26, 2023
… in the Transform Widget (#781) ## Summary: Team-LC has noticed recently that the skip rate on our transformer widget was quite a bit higher than it is normally. After further investigation, we discovered that the "homothety"/dilation tool is spitting out a large barrage of errors and is no longer functional. We suspect this is likely the main cause for the increase in reports. @jeanettehead and I looked into the history of the file and noticed that a key line of code was accidentally shifted to be a part of a parent comment as part of a [PR that removed all references to flow in Perseus](#457). `center: self.dilationCircle.centerPoint.coord` It looks like a pesky little newline was accidentally (and likely automatically) removed, causing us to lose access to the required "center" property for our dilation tool. Since this widget is deprecated and only sees minimal use in our international content, the visibility of the issue was incredibly low. Thankfully the new Perseus Widget Analyzer by @pmcgill88 helped us catch this issue by providing greater insight into how our widgets are being actively used. Issue: LC-1384 ## Test plan: manual testing Author: SonicScrewdriver Reviewers: jeanettehead, SonicScrewdriver, jeremywiebe, kevinbarabash Required Reviewers: Approved By: jeremywiebe Checks: ✅ codecov/project, ❌ codecov/patch, ✅ Upload Coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 16.x), ✅ Cypress (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 16.x), ✅ gerald Pull Request URL: #781
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR makes the following changes:
Issue: None
Test plan: