Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per-package coverage reporting [work-in-progress] #465

Closed
wants to merge 2 commits into from

Conversation

kevinbarabash
Copy link
Contributor

@kevinbarabash kevinbarabash commented Apr 12, 2023

Summary:

Flow had a command to generate coverage reports for a whole project, but TS doesn't have this capability. There is a third party package called typescript-coverage-report that provides this capability. I added a npm script "type:coverage" that can be used to produce type coverage reports for an individual package. For some reason it doesn't work with the base tsconfig.json.

Issue: None

TODO:

Test plan:

  • $PKG=perseus yarn type:coverage
  • see that it prints the report in the terminal
  • open ts-coverage/index.html to see an HTML version of the repo

Screen Shot 2023-04-12 at 10 45 58 AM

Screen Shot 2023-04-12 at 10 46 14 AM

@kevinbarabash kevinbarabash self-assigned this Apr 12, 2023
@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2023

🦋 Changeset detected

Latest commit: 4a45229

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kevinbarabash kevinbarabash requested a review from a team April 12, 2023 14:44
@khan-actions-bot khan-actions-bot requested a review from a team April 12, 2023 14:44
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Apr 12, 2023

Gerald

Required Reviewers
  • @Khan/perseus for changes to .gitignore, package.json, yarn.lock, .changeset/afraid-timers-juggle.md

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2023

Size Change: 0 B

Total Size: 652 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38 kB
packages/kmath/dist/es/index.js 4.13 kB
packages/math-input/dist/es/index.js 60.3 kB
packages/perseus-editor/dist/es/index.js 114 kB
packages/perseus-error/dist/es/index.js 705 B
packages/perseus-linter/dist/es/index.js 21.2 kB
packages/perseus/dist/es/index.js 398 kB
packages/pure-markdown/dist/es/index.js 3.65 kB
packages/simple-markdown/dist/es/index.js 12.6 kB

compressed-size-action

@kevinbarabash kevinbarabash changed the title Add per-package coverage reporting [experiment] Add per-package coverage reporting [work-in-progress] Apr 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2023

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (c6e8014) and published it to npm. You
can install it using the tag PR465.

Example:

yarn add @khanacademy/perseus@PR465

@coveralls
Copy link
Collaborator

coveralls commented Apr 12, 2023

Coverage Status

Coverage: 42.994% (-0.003%) from 42.997% when pulling 4a45229 on type-cov-report into 22c5d56 on main.

@jeresig jeresig marked this pull request as draft April 19, 2023 13:37
@jeresig jeresig removed request for a team April 19, 2023 13:38
@kevinbarabash
Copy link
Contributor Author

This is superseded by #505.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants