Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tooltip direction types enums #497

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Conversation

jeremywiebe
Copy link
Collaborator

Summary:

Originally when I modernized the tooltip.tsx component, I ran into issues converting the HorizontalDirection and VerticalDirection types to enums. Kevin asked what those were so I took another run at it... and it works. 🎉

Issue: "none"

Test plan:

yarn typecheck

@jeremywiebe jeremywiebe self-assigned this Apr 26, 2023
@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2023

🦋 Changeset detected

Latest commit: 751a630

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jeremywiebe jeremywiebe marked this pull request as ready for review April 26, 2023 17:03
@jeremywiebe jeremywiebe requested review from kevinbarabash and a team April 26, 2023 17:03
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/many-gifts-attend.md, packages/perseus/src/components/input-with-examples.tsx, packages/perseus/src/components/tooltip.tsx, packages/perseus/src/widgets/expression.tsx, packages/perseus/src/components/__stories__/tooltip.stories.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2023

Size Change: +131 B (0%)

Total Size: 790 kB

Filename Size Change
packages/perseus/dist/es/index.js 397 kB +131 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38 kB
packages/kmath/dist/es/index.js 4.13 kB
packages/math-input/dist/es/index.js 58.9 kB
packages/perseus-editor/dist/es/index.js 254 kB
packages/perseus-error/dist/es/index.js 705 B
packages/perseus-linter/dist/es/index.js 21.2 kB
packages/pure-markdown/dist/es/index.js 3.65 kB
packages/simple-markdown/dist/es/index.js 12.6 kB

compressed-size-action

@coveralls
Copy link
Collaborator

coveralls commented Apr 26, 2023

Coverage Status

Coverage: 43.594% (+0.005%) from 43.589% when pulling 751a630 on tooltip-direction-enums into 5432857 on main.

Copy link
Contributor

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for creating enums for these. 🎉

@jeremywiebe jeremywiebe merged commit 612b7f9 into main Apr 26, 2023
@jeremywiebe jeremywiebe deleted the tooltip-direction-enums branch April 26, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants