-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tooltip direction types enums #497
Conversation
🦋 Changeset detectedLatest commit: 751a630 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: +131 B (0%) Total Size: 790 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for creating enums for these. 🎉
Summary:
Originally when I modernized the
tooltip.tsx
component, I ran into issues converting theHorizontalDirection
andVerticalDirection
types to enums. Kevin asked what those were so I took another run at it... and it works. 🎉Issue: "none"
Test plan:
yarn typecheck