Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in exports #511

Merged
merged 2 commits into from
May 8, 2023
Merged

Fix a typo in exports #511

merged 2 commits into from
May 8, 2023

Conversation

nedredmond
Copy link
Contributor

@nedredmond nedredmond commented May 5, 2023

Just fixing a minor oopsie in naming exports for pages.

LC-796

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2023

🦋 Changeset detected

Latest commit: d19896e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@khanacademy/math-input Patch
@khanacademy/perseus Patch
@khanacademy/perseus-editor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team May 5, 2023 21:34
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented May 5, 2023

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/mighty-jobs-beg.md, packages/math-input/src/components/keypad/geometry-page/index.tsx, packages/math-input/src/components/keypad/operators-page/index.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Size Change: 0 B

Total Size: 790 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38 kB
packages/kmath/dist/es/index.js 4.13 kB
packages/math-input/dist/es/index.js 58.7 kB
packages/perseus-editor/dist/es/index.js 254 kB
packages/perseus-error/dist/es/index.js 705 B
packages/perseus-linter/dist/es/index.js 21.2 kB
packages/perseus/dist/es/index.js 397 kB
packages/pure-markdown/dist/es/index.js 3.65 kB
packages/simple-markdown/dist/es/index.js 12.6 kB

compressed-size-action

@coveralls
Copy link
Collaborator

coveralls commented May 5, 2023

Coverage Status

Coverage: 43.552% (-0.003%) from 43.555% when pulling d19896e on ned/fix-export-mistake into e86cc72 on main.

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (4196f11) and published it to npm. You
can install it using the tag PR511.

Example:

yarn add @khanacademy/perseus@PR511

Copy link
Member

@benchristel benchristel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nedredmond nedredmond merged commit 1ffbe3e into main May 8, 2023
@nedredmond nedredmond deleted the ned/fix-export-mistake branch May 8, 2023 18:21
nedredmond added a commit that referenced this pull request May 8, 2023
Just fixing a minor oopsie in naming exports for pages.

LC-796

Author: nedredmond

Reviewers: benchristel

Required Reviewers:

Approved By: benchristel

Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Lint, Typecheck, and Test (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ gerald, ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Lint, Typecheck, and Test (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ gerald

Pull Request URL: #511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants