-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MathInput v2 keypad layout #587
Conversation
🦋 Changeset detectedLatest commit: f8aef08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: +35 B (0%) Total Size: 811 kB
ℹ️ View Unchanged
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (506d621) and published it to npm. You Example: yarn add @khanacademy/perseus@PR587 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great LGTM!
@@ -0,0 +1,5 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will always be amused by these changesets.
|
||
const cursorKeyConfig = getCursorContextConfig(cursorContext); | ||
const fracCoord: readonly [number, number] = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be good to add a comment here to explain fracCoord for our future selves. :) Not a blocker at all.
Summary:
Updates the layout of the v2 keypad per the ticket:
Changes to the keypad layout, explained as 0-indexed coordinates (top left button is x:0, y:0)
Screen.Recording.2023-06-27.at.12.17.39.PM.mov
Issue: LC-976