Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MathInput v2 keypad layout #587

Merged
merged 4 commits into from
Jun 27, 2023
Merged

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Jun 27, 2023

Summary:

Updates the layout of the v2 keypad per the ticket:

Changes to the keypad layout, explained as 0-indexed coordinates (top left button is x:0, y:0)

  • On all pages movement key will be 4, 3
  • On the Numbers page, add “Percent” to 3, 0 (only on Numbers page)
  • On the Numbers / Pre-Algebra page, move “Fraction” to 3, 1
  • On Geometry / Extras page, move “Fraction” to 3, 0
  • Make “extras” key a 3x4 grid vs a 4x4 grid, to accommodate “Fraction” key
Screen.Recording.2023-06-27.at.12.17.39.PM.mov

Issue: LC-976

@handeyeco handeyeco self-assigned this Jun 27, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2023

🦋 Changeset detected

Latest commit: f8aef08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@khanacademy/math-input Minor
@khanacademy/perseus Patch
@khanacademy/perseus-editor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team June 27, 2023 17:17
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/slimy-gorillas-return.md, packages/math-input/src/components/keypad/button-assets.tsx, packages/math-input/src/components/keypad/index.tsx, packages/math-input/src/components/keypad/shared-keys.tsx, packages/math-input/src/components/keypad/keypad-pages/extras-page.tsx, packages/math-input/src/components/keypad/keypad-pages/numbers-page.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@handeyeco handeyeco changed the title update keypad layout Update MathInput v2 keypad layout Jun 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

Size Change: +35 B (0%)

Total Size: 811 kB

Filename Size Change
packages/math-input/dist/es/index.js 77.6 kB +35 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38 kB
packages/kmath/dist/es/index.js 4.13 kB
packages/perseus-core/dist/es/index.js 55 B
packages/perseus-editor/dist/es/index.js 256 kB
packages/perseus-error/dist/es/index.js 705 B
packages/perseus-linter/dist/es/index.js 21.2 kB
packages/perseus/dist/es/index.js 397 kB
packages/pure-markdown/dist/es/index.js 3.65 kB
packages/simple-markdown/dist/es/index.js 12.6 kB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (506d621) and published it to npm. You
can install it using the tag PR587.

Example:

yarn add @khanacademy/perseus@PR587

Copy link
Contributor

@SonicScrewdriver SonicScrewdriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great LGTM!

@@ -0,0 +1,5 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will always be amused by these changesets.


const cursorKeyConfig = getCursorContextConfig(cursorContext);
const fracCoord: readonly [number, number] =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to add a comment here to explain fracCoord for our future selves. :) Not a blocker at all.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 45.456% (+0.01%) from 45.444% when pulling f8aef08 on LC-976/button-arrangement into 1bad1cb on main.

@handeyeco handeyeco merged commit 5f71cd0 into main Jun 27, 2023
@handeyeco handeyeco deleted the LC-976/button-arrangement branch June 27, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants