Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove moved (and duplicated) LinterContextProps #674

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Conversation

jeremywiebe
Copy link
Collaborator

Summary:

I noticed that we have two identical versions of LinterContextProps. It was moved into the perseus-linter package, but I suspect a merge resolution brought back the deleted copy.

This PR deletes it again out of @khanacademy/perseus and updates imports to use the one that lives in @khanacademy/perseus-linter

Issue: "none"

Test plan:

yarn test
yarn typecheck

@jeremywiebe jeremywiebe self-assigned this Aug 17, 2023
@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023

🦋 Changeset detected

Latest commit: 4cbfdec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@khanacademy/perseus Major
@khanacademy/perseus-editor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jeremywiebe jeremywiebe requested a review from a team August 17, 2023 19:18
@jeremywiebe jeremywiebe marked this pull request as ready for review August 17, 2023 19:18
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/purple-pianos-jog.md, packages/perseus/src/hint-renderer.tsx, packages/perseus/src/index.ts, packages/perseus/src/item-renderer.tsx, packages/perseus/src/renderer.tsx, packages/perseus/src/types.ts, packages/perseus/src/widget-container.tsx, packages/perseus/src/components/input-with-examples.tsx, packages/perseus/src/components/sortable.tsx, packages/perseus/src/widgets/passage-ref.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

Size Change: 0 B

Total Size: 846 kB

ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38 kB
packages/kmath/dist/es/index.js 4.12 kB
packages/math-input/dist/es/index.js 102 kB
packages/perseus-core/dist/es/index.js 55 B
packages/perseus-editor/dist/es/index.js 268 kB
packages/perseus-error/dist/es/index.js 705 B
packages/perseus-linter/dist/es/index.js 21.2 kB
packages/perseus/dist/es/index.js 396 kB
packages/pure-markdown/dist/es/index.js 3.64 kB
packages/simple-markdown/dist/es/index.js 12.6 kB

compressed-size-action

@coveralls
Copy link
Collaborator

coveralls commented Aug 17, 2023

Coverage Status

coverage: 69.329% (+0.004%) from 69.325% when pulling 4cbfdec on linter-context into 7b11736 on main.

Copy link
Contributor

@handeyeco handeyeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Good catch

@github-actions
Copy link
Contributor

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (61c83f8) and published it to npm. You
can install it using the tag PR674.

Example:

yarn add @khanacademy/perseus@PR674

@jeremywiebe jeremywiebe merged commit 9eb50ae into main Aug 22, 2023
9 checks passed
@jeremywiebe jeremywiebe deleted the linter-context branch August 22, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants