-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove moved (and duplicated) LinterContextProps #674
Conversation
🦋 Changeset detectedLatest commit: 4cbfdec The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: 0 B Total Size: 846 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Good catch
f01d2f4
to
4cbfdec
Compare
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (61c83f8) and published it to npm. You Example: yarn add @khanacademy/perseus@PR674 |
Summary:
I noticed that we have two identical versions of
LinterContextProps
. It was moved into theperseus-linter
package, but I suspect a merge resolution brought back the deleted copy.This PR deletes it again out of
@khanacademy/perseus
and updates imports to use the one that lives in@khanacademy/perseus-linter
Issue: "none"
Test plan:
yarn test
yarn typecheck