Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow in the y direction on radio choice #706

Merged
merged 7 commits into from
Sep 7, 2023
Merged

Conversation

nixterrimus
Copy link
Contributor

@nixterrimus nixterrimus commented Sep 7, 2023

Summary:

Fixes radio choice showing a scrollbar in the y direction when showing MathJax.

image

Issue: https://khanacademy.atlassian.net/browse/LC-1177

Test plan:

Additionally

  • Python content should continue to be scrollable in the x direction

@nixterrimus nixterrimus self-assigned this Sep 7, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

🦋 Changeset detected

Latest commit: 1956531

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@khanacademy/perseus Minor
@khanacademy/perseus-editor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nixterrimus nixterrimus requested review from nedredmond and a team September 7, 2023 17:54
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Sep 7, 2023

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/nasty-islands-sin.md, packages/perseus/src/widgets/radio/choice.tsx, packages/perseus/src/multi-items/__tests__/__snapshots__/multi-renderer.test.tsx.snap, packages/perseus/src/widgets/__tests__/__snapshots__/group.test.tsx.snap, packages/perseus/src/widgets/__tests__/__snapshots__/radio.test.ts.snap

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (033075c) and published it to npm. You
can install it using the tag PR706.

Example:

yarn add @khanacademy/perseus@PR706

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Size Change: +8 B (0%)

Total Size: 847 kB

Filename Size Change
packages/perseus/dist/es/index.js 396 kB +8 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38 kB
packages/kmath/dist/es/index.js 4.12 kB
packages/math-input/dist/es/index.js 103 kB
packages/perseus-core/dist/es/index.js 55 B
packages/perseus-editor/dist/es/index.js 268 kB
packages/perseus-error/dist/es/index.js 705 B
packages/perseus-linter/dist/es/index.js 21.2 kB
packages/pure-markdown/dist/es/index.js 3.64 kB
packages/simple-markdown/dist/es/index.js 12.6 kB

compressed-size-action

Copy link
Member

@benchristel benchristel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left a suggestion inline about the changeset, which you can take or leave.

.changeset/nasty-islands-sin.md Outdated Show resolved Hide resolved
Co-authored-by: Ben Christel <benchristel@users.noreply.github.com>
Copy link
Contributor

@nedredmond nedredmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, @nixterrimus !

@nixterrimus nixterrimus merged commit 8dc8690 into main Sep 7, 2023
9 checks passed
@nixterrimus nixterrimus deleted the new/overflow-bars branch September 7, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants