-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overflow in the y direction on radio choice #706
Conversation
🦋 Changeset detectedLatest commit: 1956531 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (033075c) and published it to npm. You Example: yarn add @khanacademy/perseus@PR706 |
Size Change: +8 B (0%) Total Size: 847 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left a suggestion inline about the changeset, which you can take or leave.
Co-authored-by: Ben Christel <benchristel@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks, @nixterrimus !
Summary:
Fixes radio choice showing a scrollbar in the y direction when showing MathJax.
Issue: https://khanacademy.atlassian.net/browse/LC-1177
Test plan:
Additionally