Restore i18n._() support for radio widget's Choice component #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +19 B (0%) Total Size: 817 kB
ℹ️ View Unchanged
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #986 +/- ##
==========================================
+ Coverage 63.51% 64.72% +1.21%
==========================================
Files 421 423 +2
Lines 96123 96366 +243
Branches 6253 8663 +2410
==========================================
+ Hits 61049 62377 +1328
+ Misses 35074 33989 -1085
... and 70 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
handeyeco
approved these changes
Feb 12, 2024
Merged
jeremywiebe
pushed a commit
that referenced
this pull request
Feb 13, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus-dev-ui@1.1.0 ### Minor Changes - [#988](#988) [`bbdb3377`](bbdb337) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Add more graph types to the dev UI ## @khanacademy/perseus@19.1.9 ### Patch Changes - [#986](#986) [`585a3fe9`](585a3fe) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Wrap some radio widget strings that a learner would see in `i18n._()` calls so they can be localized. - [#987](#987) [`e4ca3c53`](e4ca3c5) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Move Graphie's addMouseLayer function directly onto class (avoid metaprogramming) - [#979](#979) [`9f2eafe4`](9f2eafe) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Improve types for Graphie's getMousePx and getMouseCoord functions - [#975](#975) [`36a5ebe1`](36a5ebe) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Add tests to cover Graphie's addMouseLayer() function - includes some related type improvements. ## @khanacademy/perseus-editor@4.1.9 ### Patch Changes - Updated dependencies \[[`585a3fe9`](585a3fe), [`e4ca3c53`](e4ca3c5), [`9f2eafe4`](9f2eafe), [`36a5ebe1`](36a5ebe)]: - @khanacademy/perseus@19.1.9 Author: khan-actions-bot Reviewers: jeremywiebe Required Reviewers: Approved By: jeremywiebe Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage, ⏭ Publish npm snapshot, ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Extract i18n strings (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #990
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While removing
perseus-legacyfrom webapp (https://github.com/Khan/webapp/pull/19729/files) Adam G asked about the string removals. I assumed (incorrectly) that they were just due to removal of deprecated/unsupported features. It turns out that some were changes we've made to Perseus over time where we missed wrapping user-facing strings ini18n._()after a refactoring.This PR restores the ones that I could identify by searching Perseus for the strings being removed in Khan/webapp#19729.
Issue: "none"
Test plan:
I searched each removed string in Khan/webapp#19729 in the Perseus repo. Each one that I found I ensured was now wrapped in
i18n._()calls again.