-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Wrapped{Ellipse,Line,Path} to be ES6 classes #995
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: -645 B (0%) Total Size: 815 kB
ℹ️ View Unchanged
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #995 +/- ##
==========================================
+ Coverage 63.67% 64.71% +1.04%
==========================================
Files 423 427 +4
Lines 96516 96456 -60
Branches 6283 8660 +2377
==========================================
+ Hits 61452 62426 +974
+ Misses 35064 34030 -1034
... and 69 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (66cbf59) and published it to npm. You Example: yarn add @khanacademy/perseus@PR995 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments from browsing this PR. I'll leave full review/approval for the keyboard team (Ned/Mark). :)
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus@19.2.0 ### Minor Changes - [#989](#989) [`97b5bbfb`](97b5bbf) Thanks [@aag](https://github.com/aag)! - Add a new python-program widget and its editor ### Patch Changes - [#995](#995) [`a4ead994`](a4ead99) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Refactor wrapped Raphael SVGs to be ES6 classes - [#995](#995) [`a4ead994`](a4ead99) Thanks [@benchristel](https://github.com/benchristel)! - Update formatting for Prettier 2.8.8 - Updated dependencies \[[`a4ead994`](a4ead99)]: - @khanacademy/math-input@17.0.8 - @khanacademy/perseus-linter@0.3.12 - @khanacademy/pure-markdown@0.2.15 ## @khanacademy/perseus-editor@4.2.0 ### Minor Changes - [#989](#989) [`97b5bbfb`](97b5bbf) Thanks [@aag](https://github.com/aag)! - Add a new python-program widget and its editor ### Patch Changes - [#995](#995) [`a4ead994`](a4ead99) Thanks [@benchristel](https://github.com/benchristel)! - Update formatting for Prettier 2.8.8 - Updated dependencies \[[`a4ead994`](a4ead99), [`a4ead994`](a4ead99), [`97b5bbfb`](97b5bbf)]: - @khanacademy/perseus@19.2.0 - @khanacademy/math-input@17.0.8 ## @khanacademy/perseus-dev-ui@1.1.1 ### Patch Changes - [#995](#995) [`a4ead994`](a4ead99) Thanks [@benchristel](https://github.com/benchristel)! - Internal: Refactor wrapped Raphael SVGs to be ES6 classes - [#995](#995) [`a4ead994`](a4ead99) Thanks [@benchristel](https://github.com/benchristel)! - Update formatting for Prettier 2.8.8 - Updated dependencies \[[`a4ead994`](a4ead99)]: - @khanacademy/math-input@17.0.8 - @khanacademy/perseus-linter@0.3.12 - @khanacademy/pure-markdown@0.2.15 ## @khanacademy/math-input@17.0.8 ### Patch Changes - [#995](#995) [`a4ead994`](a4ead99) Thanks [@benchristel](https://github.com/benchristel)! - Update formatting for Prettier 2.8.8 ## @khanacademy/perseus-error@0.2.11 ### Patch Changes - [#995](#995) [`a4ead994`](a4ead99) Thanks [@benchristel](https://github.com/benchristel)! - Update formatting for Prettier 2.8.8 ## @khanacademy/perseus-linter@0.3.12 ### Patch Changes - Updated dependencies \[[`a4ead994`](a4ead99)]: - @khanacademy/perseus-error@0.2.11 ## @khanacademy/pure-markdown@0.2.15 ### Patch Changes - Updated dependencies \[[`a4ead994`](a4ead99)]: - @khanacademy/perseus-error@0.2.11
This enables better typechecking in the area of the code we want to change
next.
Issue: none
Test plan:
You should see a bunch of working interactive graphs