Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🔥AUDIT🔥] Add note for how to use npm snapshot in webapp #999

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

jeremywiebe
Copy link
Collaborator

Summary:

Today we note how to use the npm snapshot generally, but most folks are integrating their changes into webapp today so I'm adding a note for how to use the script in webapp.

Issue: "none"

Test plan:

@jeremywiebe jeremywiebe self-assigned this Feb 14, 2024
@jeremywiebe jeremywiebe marked this pull request as ready for review February 14, 2024 23:10
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .github/workflows/node-ci.yml

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team February 14, 2024 23:11
Copy link
Contributor

github-actions bot commented Feb 14, 2024

Size Change: +900 B (0%)

Total Size: 815 kB

Filename Size Change
packages/math-input/dist/es/index.js 79.9 kB +164 B (0%)
packages/perseus/dist/es/index.js 391 kB +736 B (0%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.1 kB
packages/kmath/dist/es/index.js 4.27 kB
packages/perseus-core/dist/es/index.js 908 B
packages/perseus-editor/dist/es/index.js 263 kB
packages/perseus-error/dist/es/index.js 878 B
packages/perseus-linter/dist/es/index.js 21.8 kB
packages/pure-markdown/dist/es/index.js 3.77 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.62%. Comparing base (e991bf9) to head (f9ee87b).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #999      +/-   ##
==========================================
+ Coverage   63.70%   65.62%   +1.91%     
==========================================
  Files         425      428       +3     
  Lines       96439    96584     +145     
  Branches     6298     9023    +2725     
==========================================
+ Hits        61441    63383    +1942     
+ Misses      34998    33201    -1797     

Impacted file tree graph

see 80 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e991bf9...f9ee87b. Read the comment docs.

@jeremywiebe jeremywiebe changed the title Add note for how to use npm snapshot in webapp [🔥AUDIT🔥] Add note for how to use npm snapshot in webapp Feb 26, 2024
Copy link
Contributor

npm Snapshot: NOT Published

Oh noes!! We couldn't find any changesets in this PR (f9ee87b). As a result, we did not
publish an npm snapshot for you.

@jeremywiebe jeremywiebe merged commit f60fe57 into main Feb 26, 2024
24 checks passed
@jeremywiebe jeremywiebe deleted the npm-snapshot.webapp-instructions branch February 26, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants