-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use only conda-forge for building the binary Khiops Conda packages #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folmos-at-orange
approved these changes
Aug 5, 2024
bruno-at-orange
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
popescu-v
force-pushed
the
for_testing_conda-forge_only
branch
from
August 8, 2024 10:11
a59226c
to
5b1bdea
Compare
This achieved by using Miniforge3 in the setup-miniconda GitHub action. Thus, only the `conda-forge` channel is used and there is no need of channel overriding.
…Hub runner Thus, Ninja / VS interaction errors are partially mitigated. See actions/runner-images#9701.
…nja on Windows This is because Ninja does not expect target platform and generator toolset. However, CMake Windows presets set these, which results in Ninja failure.
popescu-v
force-pushed
the
for_testing_conda-forge_only
branch
from
October 1, 2024 12:38
ce79b82
to
8f0069c
Compare
Disable "floating-point expression contraction" on clang and gcc to improve reproducibility between x86_64 and arm64. This change impacts: - Linux native builds - Conda builds for: - Linux - Mac OS: ARM and X86_64 architectures
popescu-v
force-pushed
the
for_testing_conda-forge_only
branch
from
October 1, 2024 12:52
8f0069c
to
ff7444c
Compare
bruno-at-orange
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue KhiopsML/khiops-python#189
Closes #388