Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only conda-forge for building the binary Khiops Conda packages #341

Merged
merged 6 commits into from
Oct 2, 2024

Conversation

popescu-v
Copy link
Collaborator

@popescu-v popescu-v commented Aug 2, 2024

Related issue KhiopsML/khiops-python#189

Closes #388

packaging/conda/bld.bat Show resolved Hide resolved
src/Learning/KWUtils/KWKhiopsVersion.h Outdated Show resolved Hide resolved
Copy link
Contributor

@bruno-at-orange bruno-at-orange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This achieved by using Miniforge3 in the setup-miniconda GitHub action.

Thus, only the `conda-forge` channel is used and there is no need of
channel overriding.
…Hub runner

Thus, Ninja / VS interaction errors are partially mitigated.

See actions/runner-images#9701.
…nja on Windows

This is because Ninja does not expect target platform and generator
toolset.
However, CMake Windows presets set these, which results in Ninja failure.
bruno-at-orange and others added 2 commits October 1, 2024 14:51
Disable "floating-point expression contraction" on clang and gcc to
improve reproducibility between x86_64 and arm64.

This change impacts:

- Linux native builds
- Conda builds for:
  - Linux
  - Mac OS: ARM and X86_64 architectures
Copy link
Contributor

@bruno-at-orange bruno-at-orange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@popescu-v popescu-v merged commit 74911ec into dev-v10 Oct 2, 2024
55 of 97 checks passed
@popescu-v popescu-v deleted the for_testing_conda-forge_only branch October 2, 2024 14:17
@popescu-v popescu-v mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build the Conda Packages Using Only the conda-forge Channel
3 participants