Fix system memory size of tvOS #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
billhollings
requested changes
Dec 18, 2023
There was a problem hiding this comment.
Thanks for the submission!
So strange that tvOS is the only platform that doesn't support host_info().
However, in testing your submission here, sysctlbyname() is available on all platforms, and gives the same numeric results as host_info() on both macOS and iOS.
So, can you modify this PR to remove the platform compile macros, and just use your new code for all platforms, please?
karelrooted
force-pushed
the
fix-tvos-memory-size
branch
from
5bbb7d7
to
defaafe
Compare
use sysctlbyname("hw.memsize") to get sytem memory size instead of host_info,
host_info is not available on tvOS, so we change to sysctlbyname which support all apple platforms
apple document didn't stat this API is available on tvOS though,
https://developer.apple.com/documentation/kernel/1387446-sysctlbyname
karelrooted
force-pushed
the
fix-tvos-memory-size
branch
from
defaafe
to
d483d62
Compare
|
PR is updated to use sysctlbyname to get system memory size for all apple platforms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use sysctlbyname("hw.memsize") to get sytem memory size instead of host_info, host_info is not available on tvOS, so we change to sysctlbyname which support all apple platforms
the sytem memory size of tvOS is hardcoded as 0 currently, found this bug while using libplacebo's vulkan render to play video on tvOS
apple document didn't stat this API is available on tvOS though