-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assert in tvOS #229
Comments
b63864e should fix this |
i will recompile everything but i'm already using latest commit in master 52314e0 I tried to revert back to tag v6.338.1 and i don't get the assert but i get this
and a blue screen. |
@haasn i've recompiled everything and the problem is only in tvOS. iOS is working |
@haasn what do you need to help you fix this problem? it is working for iOS so it must be some small thing that is broken for tvOS. |
From your log, the biggest issue I see is that the available memory size is reported as 0:
I don't know, however, how this could lead to the assertion, which should just be completely impossible. (We explicitly set |
i will try to setup some demo app where i can add breakpoints to libplacebo and check why it fails to get that info. |
with the latest git master , there is no assert on my env though [Apple TV 4K 2017 (tvOS 17.2) (vo=gpu-next) ]
available memory size is reported as 0 too, mpv play the video file with audio but no video here is the fulllog |
it seems the memory heap size 0 in tvOS is hardcoded in MoltenVK/Common/MVKOSExtensions.mm#L112 after fix the memory size to return correct value, the bug is fixed, and the video plays fine, please update MoltenVK to the latest git if use old device , you probably want to change profile to fast, basic on a quick test, the performance on Apple TV 4K 2017 is poor with default profile, when play a 4k dolby vision demo video , a lot of frame drop in output, mpv log after change profile to fast, the video play fine with no frame drop by the way ,while we are here, the Xcode debug mode sigabort error issue is happened too in this vo=gpu-next mode (similar, but not in the same code) , I can't get the macOS version running against official Vulkan SDK to work, is there any other way to enable VVL without using official SDK? |
thanks @karelrooted! Really nice progress that you got here |
@karelrooted I did a search for |
I get an assert when i try to run MPV in tvOS with support for vulkan.
I'm using latest commits of libplacebo, mpv and MoltenVK, but if i downgrade to some stable tag idon't get the assert but it fails to generate the texture with:
Logs for latest versions of all dependencies:
The text was updated successfully, but these errors were encountered: