Remove use of @available() directive as it can cause issues in some build environments. #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set ARCHS build setting to $(ARCHS_STANDARD_64_BIT) in Xcode projects. Remove ARCHS and VALID_ARCHS build settings in Xcode targets.
…Controller tool. The tool will be built during MoltenVK build, and rebuilding just the tool was clearing away the main MoltenVK build.
…uild environments. Generally replace use of @available() with respondsToSelector:. Add mvkMakeOSVersion() and mvkOSVersionIsAtLeast(macos,ios) to help testing OS versions. Set maxDrawIndexedIndexValue to kMVKUndefinedLargeUInt32 instead of uint32_t max.
cdavis5e
reviewed
Jun 11, 2020
| @@ -1476,7 +1476,7 @@ | |||
| _properties.limits.maxComputeWorkGroupCount[1] = kMVKUndefinedLargeUInt32; | |||
| _properties.limits.maxComputeWorkGroupCount[2] = kMVKUndefinedLargeUInt32; | |||
|
|
|||
| _properties.limits.maxDrawIndexedIndexValue = numeric_limits<uint32_t>::max(); | |||
| _properties.limits.maxDrawIndexedIndexValue = kMVKUndefinedLargeUInt32; | |||
There was a problem hiding this comment.
Why? If the fullDrawIndexUint32 feature is supported, this is required to be the maximum uint32_t value. That's why I changed it to set it to numeric_limits<uint32_t>::max() in the first place. DXVK requires this for feature level 10 support, because all D3D10+ hardware supports it, and I'm pretty sure Metal (at least, on desktop) requires D3D11+ hardware.
There was a problem hiding this comment.
Shoot! My bad. I just interpreted it as a typo...without fully absorbing how that limit is special.
Fixing it now...
There was a problem hiding this comment.
Thanks for catching that! 🤦🏻♂️😏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@available()directive as it can cause issues in some build environments.API-Samples generateSPIRVShadersno longer buildsMoltenVKShaderConvetertool.Fixes issue #913.