Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove harmless but potentially confusing "Module" references #2

Closed
cdwfs opened this issue Oct 9, 2017 · 3 comments
Closed

Remove harmless but potentially confusing "Module" references #2

cdwfs opened this issue Oct 9, 2017 · 3 comments

Comments

@cdwfs
Copy link
Collaborator

cdwfs commented Oct 9, 2017

It looks like the ShaderReflection class was renamed from "Module" at some point, but several references to the old name (class comment, "m_module" and "p_module" variables) still exist.
@cdwfs
Copy link
Collaborator Author

cdwfs commented Oct 9, 2017

Same general issue in the non-opaque branch.

@chaoticbob
Copy link
Contributor

I've been back and forth on this. Any opinions on what makes more sense?

@chaoticbob
Copy link
Contributor

Renamed to ShaderModule.

@chaoticbob chaoticbob mentioned this issue Apr 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chaoticbob @cdwfs