Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator: allow unreachable continue construct under certain conditions #276

Closed
dneto0 opened this issue Jul 26, 2016 · 2 comments
Closed
Assignees

Comments

@dneto0
Copy link
Collaborator

dneto0 commented Jul 26, 2016

This issue tracks validator changes for changes expected from resolution to KhronosGroup/SPIRV-Headers#16

Related to
#270

Currently, the validator disallows an unreachable continue construct for a loop. I expect we should relax this rule.

@dneto0
Copy link
Collaborator Author

dneto0 commented Aug 5, 2016

With b51b809 the validator now will find an unreachable continue construct.

It finds candidate back-edges via a special forward depth-first-search in the augmented CFG that also adds an edge from any block with an OpLoopMerge %merge %cont instruction to the named continue target %cont. But that DFS is not used for computing dominance.

@dneto0 dneto0 closed this as completed Aug 5, 2016
@dneto0
Copy link
Collaborator Author

dneto0 commented Aug 5, 2016

Still need to take this feedback to the SPIR working group to resolve KhronosGroup/SPIRV-Headers#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant