(Deprecated API) Remove has_extension() and replace it with .has() method #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kovshikovser
commented
Sep 1, 2021
kovshikovser
commented
- All has_extension(string) calls replaced with has(aspect)
- Removed has_extension(string) calls with extension without corresponding sycl::aspect (according to Table 189. "SYCL support for OpenCL 1.2 extensions" from the SYCL 2020 Spec)
kovshikovser
requested review from
bader,
illuhad,
keryell and
ProGTX
as code owners
keryell
approved these changes
Sep 1, 2021
|
I wonder if there are any plans to have some separate test category for deprecated APIs. Deprecation doesn't mean removal and it still means that the functionality must be supported. What is CTS development strategy in that regard? |
ProGTX
approved these changes
Sep 6, 2021
Good question. I've created #172 to discuss it separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.