Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for sycl::get_kernel_id and sycl::get_kernel_ids #218

Merged
merged 8 commits into from
Jan 10, 2022

Conversation

vasilytric
Copy link
Contributor

Some of these test required containing in separate *.exe-file: get_kernel_ids_multiple_kernels, get_kernel_ids_single_kernel and get_kernel_ids_no_kernels because these files required stricted list of available kernels
for build this tests need call building process for each test separately: make test_get_kernel_ids_multiple_kernels, make test_get_kernel_ids_single_kernel and make test_get_kernel_ids_no_kernels
But if use make all tests will be builded

Following tests created:
 - tests for common-by-reference checks.
 - tests for sycl::kernel_id API
/** Check return type of sycl::get_kernel_id()
*/
run_verification<by_queue>(log, [&](sycl::queue &queue) {
using kernel_name = class k_id_ret_type;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I have never thought to this syntax.

tests/CMakeLists.txt Outdated Show resolved Hide resolved
tests/CMakeLists.txt Outdated Show resolved Hide resolved
tests/CMakeLists.txt Show resolved Hide resolved
Addcomments for these functions: add_cts_test and add_independent_cts_tests
…urces files

This could happen in case, when specified source *.cpp-files doesn't
exist
Previously generating process doesn't stopped in this case
These changes from the older code base
@bader bader requested a review from ProGTX December 8, 2021 09:02
@bader
Copy link
Contributor

bader commented Dec 9, 2021

@vasilytric, CI says that computecpp and hipsycl doesn't support these features yet.
Please, update corresponding filters - https://github.com/KhronosGroup/SYCL-CTS/tree/SYCL-2020/ci.

@vasilytric
Copy link
Contributor Author

@vasilytric, CI says that computecpp and hipsycl doesn't support these features yet. Please, update corresponding filters - https://github.com/KhronosGroup/SYCL-CTS/tree/SYCL-2020/ci.

@bader Oh, sorry. these files was updated in this commit: b4692ac

@psalz
Copy link
Member

psalz commented Dec 9, 2021

You say that these translation units must not be linked together -- doesn't this mean that the test_all executable will never pass? Should these tests be excluded from test_all? Of course then it no longer tests all...

@vasilytric
Copy link
Contributor Author

You say that these translation units must not be linked together -- doesn't this mean that the test_all executable will never pass? Should these tests be excluded from test_all? Of course then it no longer tests all...

Oh, this is a good question. The test_all target brings together all tests, even the tests that should be excluded from the common executable-file.
We can skip such tests during runtime (e.g.: if extra kernels were found)

We also have another way:

  • just call make command. All tests will be linked into right executables and if then launch CTest all tests will be launched with the right kernel sets

@bader
Copy link
Contributor

bader commented Jan 10, 2022

@vasilytric, please, resolve merge conflicts.

@vasilytric
Copy link
Contributor Author

@vasilytric, please, resolve merge conflicts.

@bader Done

@bader bader merged commit 0be922a into KhronosGroup:SYCL-2020 Jan 10, 2022
@bader
Copy link
Contributor

bader commented Jan 10, 2022

@vasilytric, please, update pull requests depending on changes from this PR to get valid CI checks status.

@vasilytric vasilytric deleted the kernel_bundle_get_kernel_id branch January 11, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants