Avoid tabs in command lines #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates cmake/FindComputeCpp.cmake to avoid the use of tabs in command lines. The tabs are valid but cause issues when copying and pasting commands to run them standalone, as even the pasting of a tab may trigger tab completion, depending on the shell and shell settings. The tabs were a workaround for older CMake versions, but a sufficiently recent CMake is already required.
hvdijk
requested review from
bader,
illuhad,
keryell and
ProGTX
as code owners
|
|
bader
approved these changes
Dec 6, 2021
ProGTX
approved these changes
Dec 8, 2021
keryell
reviewed
Dec 10, 2021
|
Can someone with admin rights to merge this PR, please? |
I have added you to the SYCL admin list anyway as you deserve it. :-) |
steffenlarsen
pushed a commit
to steffenlarsen/SYCL-CTS
that referenced
this pull request
Dec 6, 2022
Create local cmake_cmd array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates cmake/FindComputeCpp.cmake to avoid the use of tabs in command lines. The tabs are valid but cause issues when copying and pasting commands to run them standalone, as even the pasting of a tab may trigger tab completion, depending on the shell and shell settings.
The tabs were a workaround for older CMake versions, but a sufficiently recent CMake is already required.
I have verified that with this MR applied, with the Ninja generator, the only change to the generated
build.ninjais the removal of the tabs.Note: this PR is against SYCL-2020 but also applies cleanly to SYCL-1.2.1/master. If this gets approved and merged to SYCL-2020, I would appreciate it if it could also be cherry-picked there, or I can create a new PR for that.