Replace deprecated id -> range conversion #886
Conversation
| @@ -92,9 +92,12 @@ template <int dim> void check_dim(util::logger &log) { | |||
| local_range_total>(local_range, local_range); | |||
| cgh.parallel_for_work_group<kernel<dim>>( | |||
| groupRange, localRange, [=](sycl::group<dim> group_pid) { | |||
| sycl::range<dim> r; | |||
| auto group_id = group_pid.get_group_id(); | |||
| for (int i = 0; i < dim; ++i) r[i] = group_id[i]; | |||
There was a problem hiding this comment.
On the other hand having to write this ugly code means we missed our goals somewhere.
Perhaps for SYCL Next exposing a range interface for id and an explicit constructor from a range to a range would make it better?
|
@bader can we merge this one? |
|
@keryell - Does the Agenda label mean you would like to wait for this to get merged? |
Ah no, sorry for being unclear. This is something useful to add and we should discuss in a meeting soon. |
We're still a little confused. We may merge this PR right now, right? |
|
Yes you can merge this. |
As I understand - this API was never part of the specification.
Found out this test fails to compile after intel/llvm@f98e99c.