Add "absolute error tolerance" accuracy mode check #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though the expected precision of math builtins are now defined by the backend specifications, the CTS currently checks the error accuracy based on the tolerances specified by the OpenCL C specification. For `mix` and `smoothstep` these tolerances are defined in "absolute error tolerance" rather than in ULP. This commit makes it possible for the tests to switch between ULP and "absolute error tolerance" checks based on the builtins. Likewise, it applies these to `mix` and `smoothstep` in accordance with the OpenCL C specification. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
keryell
reviewed
May 29, 2024
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though the expected precision of math builtins are now defined by the backend specifications, the CTS currently checks the error accuracy based on the tolerances specified by the OpenCL C specification. For
mixandsmoothstepthese tolerances are defined in "absolute error tolerance" rather than in ULP. This commit makes it possible for the tests to switch between ULP and "absolute error tolerance" checks based on the builtins. Likewise, it applies these tomixandsmoothstepin accordance with the OpenCL C specification.