Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge I'm Definitely Sober features back into Sobriety #41

Merged
merged 10 commits into from
Oct 20, 2022
Merged

Merge I'm Definitely Sober features back into Sobriety #41

merged 10 commits into from
Oct 20, 2022

Commits on Oct 20, 2022

  1. Fix average relapse behavior 

    - If the addiction has never been relapsed, it's not shown at all
- The value is correctly and consistently displayed across app restarts
    @unbiaseduser-github
    unbiaseduser-github committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    7464121 View commit details
    Browse the repository at this point in the history

  2. Do not hardcode strings, to be translated to other languages

    @unbiaseduser-github
    unbiaseduser-github committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    0439e3d View commit details
    Browse the repository at this point in the history

  3. Update gradle and dependencies

    @unbiaseduser-github
    unbiaseduser-github committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    d50bd13 View commit details
    Browse the repository at this point in the history

  4. Organize files into folders

    @unbiaseduser-github
    unbiaseduser-github committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    9cad73a View commit details
    Browse the repository at this point in the history

  5. Actually use View Binding 

    also make the rest of the strings translatable bc i forgor
    @unbiaseduser-github
    unbiaseduser-github committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    24fac0c View commit details
    Browse the repository at this point in the history

  6. Move utility methods to a separate file, decouple AddictionCardAdapte… 

    …r from Main Activity
    @unbiaseduser-github
    unbiaseduser-github committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    15149ee View commit details
    Browse the repository at this point in the history

  7. Replace deprecated startActivityForResult with ActivityResultContract… 

    …s.StartActivityForResult
    @unbiaseduser-github
    unbiaseduser-github committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    aabf372 View commit details
    Browse the repository at this point in the history

  8. Don't set OnClickListeners in onBindViewHolder 

    seriously, that's bad practice
    @unbiaseduser-github
    unbiaseduser-github committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    f9401e3 View commit details
    Browse the repository at this point in the history

  9. Add a Stop button to the addiction card

    @unbiaseduser-github
    unbiaseduser-github committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    51fb82a View commit details
    Browse the repository at this point in the history

  10. Finished merging features.

    @unbiaseduser-github
    unbiaseduser-github committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    bff29c5 View commit details
    Browse the repository at this point in the history