Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

New foot prints for Valves #1111

Closed
wants to merge 5 commits into from
Closed

Conversation

Misca1234
Copy link
Collaborator

@Misca1234 Misca1234 commented Nov 25, 2018

Overhaul of the valve foot prints

All foot prints are script made (except CK6418)
All 3D models are script made

The models and foot print does not replace existing valve foot prints.
Removal of old foot prints will be done with a later push of thesymbols

Foot print push
#1111

Foot print script push
pointhi/kicad-footprint-generator#226

3D model push
KiCad/kicad-packages3D#466

3D model scripts
easyw/kicad-3d-models-in-freecad#234

bild

bild

bild

bild

bild


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@Misca1234
Copy link
Collaborator Author

Note:
The travis errors relate to that I have 2 3D models for each foot prints and one of them are placed with an offset.

@Misca1234
Copy link
Collaborator Author

Note:
The travis errors relate to that I have 2 3D models for each foot prints and one of them are placed with an offset.

@Misca1234
Copy link
Collaborator Author

Still ongoing discussion about how to construct the file name in
#1103

Closing until sorted out

@Misca1234 Misca1234 closed this Nov 29, 2018
@Misca1234 Misca1234 deleted the Valve_3D_05 branch November 29, 2018 16:47
@myfreescalewebpage myfreescalewebpage added Abandoned Original author has stopped working on the PR Addition Adds new footprint to library labels Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Abandoned Original author has stopped working on the PR Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants