Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Varistor: Add a 4.9 width version #1305

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Varistor: Add a 4.9 width version #1305

merged 2 commits into from
Jan 22, 2019

Conversation

antoniovazquezblanco
Copy link
Collaborator

Copy-paste of the 4.8mm version but slightly wider.

To be used with VDRS05C275BSE
https://www.mouser.es/datasheet/2/427/vdrs-101657.pdf

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@antoniovazquezblanco antoniovazquezblanco added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Jan 16, 2019
@poeschlr
Copy link
Collaborator

Dimension e (pitch in y direction) is not quite right.
screenshot from 2019-01-19 00-42-19

I now wonder if we need to include this dimension in the naming scheme. Maybe something we should keep in mind for version 6.

@poeschlr poeschlr self-assigned this Jan 18, 2019
@poeschlr poeschlr added Pending changes and removed Pending reviewer A pull request waiting for a reviewer labels Jan 18, 2019
@antoniovazquezblanco antoniovazquezblanco added Ready for review Use this to mark pull requests that are updated but you could not review instantly and removed Pending changes labels Jan 21, 2019
@antoniovazquezblanco
Copy link
Collaborator Author

Done!

@poeschlr
Copy link
Collaborator

Looks good, thanks
screenshot from 2019-01-22 21-18-19

@poeschlr poeschlr merged commit 6a5e8c2 into KiCad:master Jan 22, 2019
@poeschlr poeschlr removed the Ready for review Use this to mark pull requests that are updated but you could not review instantly label Jan 22, 2019
@antoniovazquezblanco
Copy link
Collaborator Author

Thanks!

@antoniovazquezblanco antoniovazquezblanco deleted the dev/varistor branch January 23, 2019 09:44
This was referenced Jan 23, 2019
Closed
Merged
DaToBSn pushed a commit to DaToBSn/kicad-footprints that referenced this pull request Jul 2, 2019
Merge branch 'master' of github.com:KiCad/kicad-footprints
a6fa9db 
* 'master' of github.com:KiCad/kicad-footprints: (26 commits)
  Changed pin 1 into a rectangle
  add SOP-8 variant by Mini-Circuits XX211 (KiCad#1335)
  add QFN-12-1EP variant from Mini-Circuits DQ1225 (KiCad#1334)
  Added the foot print for sensor DHT11
  TO-SOT SMD: Add footprint for On Semiconductor ECH8 package
  Mini-Circuits TTT167 (KiCad#1329)
  Removed Vishay_PowerPAK_SO-8, which duplicates PowerPAK_SO-8_Single (KiCad#1037)
  Mini-Circuits YY161 (KiCad#1327)
  Mini-Circuits CK605 (KiCad#1328)
  Mini-Circuits HZ1198 (KiCad#1330)
  Sensor_Temperature: Rename to "Sensor" (KiCad#1332)
  add Bourns SRF0905 line filter (KiCad#1220)
  Update 16-pin Textool socket to match all the others. (KiCad#1319)
  Mini-Circuits GP731/GP1212 plain footprint (KiCad#1315)
  Plain version of Mini-Circuits HF1139 (KiCad#1317)
  plain version of Mini-Circuits MMM168 (KiCad#1318)
  Add Mini-Circuits QQQ130 plain footprint (KiCad#1323)
  Mini-Circuits TT1224 (KiCad#1324)
  Mini-Circuits BK377 plain footprint (KiCad#1314)
  Varistor: Add a 4.9 width version (KiCad#1305)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@poeschlr poeschlr

Labels
Addition Adds new footprint to library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoniovazquezblanco @poeschlr