Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added footprints for TE SCHRACK PE0xxFxx latching relays #2225

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

amil109
Copy link
Contributor

@amil109 amil109 commented Apr 17, 2020

Added footprints for TE SCHRACK PE0xxFxx latching relays.

https://www.te.com/commerce/DocumentDelivery/DDEController?Action=showdoc&DocId=Data+Sheet%7FPE_bistable%7F0919%7Fpdf%7FEnglish%7FENG_DS_PE_bistable_0919.pdf%7F3-1415390-1


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • [ x ] Provide a URL to a datasheet for the footprint(s) you are contributing
  • [ x ] An example screenshot image is very helpful

SPST_TE_PE0xxFxx
SPDT_TE_PE0xxFxx

  • [ x ] If there are matching symbol or 3D model pull requests, provide link(s) as appropriate

KiCad/kicad-symbols#2649

  • [ TBC ] Check the output of the Travis automated check scripts - fix any errors as required
  • [ NA ] Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

@CLAassistant
Copy link

CLAassistant commented Apr 17, 2020

CLA assistant check
All committers have signed the CLA.

@myfreescalewebpage myfreescalewebpage added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Apr 17, 2020
…E_PE01xFxx_CO.kicad_mod

Updated to match changes requested on PR #2946.
…E_PE03xFxx_NO.kicad_mod

Updating as requested in PR#2946.
@myfreescalewebpage myfreescalewebpage self-assigned this Sep 23, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Sep 23, 2020
@myfreescalewebpage
Copy link
Collaborator

@amil109 starting the review of the footprint:

Relay_SPDT_TE_PE01xFxx_CO

  • Name should be "Relay_SPDT_TE_PE01xFxx"
  • You have issues about the name inside the kicad_mod file itself, see travis errors
  • Datasheet must be added in the description, like all the other footprints
  • Pin 1 need indicator on F.Fab and F.SilkS layers see other relays (Omron or Finder for example)
  • Pin 1 and 2 should be at 1.4mm from the left border
  • About the pads, the other relays with the same hole size have pad size of 3mm, you need to enlarge
  • F.SilkS clearance should be 0.11mm from F.Fab lines and 0.2mm from the pads
  • F.CrtYd clearance should be 0.25mm from F.Fab lines

Relay_SPST_TE_PE0xxFxx_NO

  • name should be "Relay_SPDT_TE_PE03xFxx"
  • the comments made for the previous relay apply to this one too

Will make a general review after those changes

Joel

@myfreescalewebpage
Copy link
Collaborator

@amil109 ping

@myfreescalewebpage myfreescalewebpage added the Abandoned Original author has stopped working on the PR label Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Abandoned Original author has stopped working on the PR Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants