Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

I added plcc4 rgb led like very popular ws2812B #554

Merged
merged 1 commit into from
Jun 25, 2019
Merged

I added plcc4 rgb led like very popular ws2812B #554

merged 1 commit into from
Jun 25, 2019

Conversation

dxrpl
Copy link
Contributor

@dxrpl dxrpl commented May 21, 2019

I added package for very popular type of LEDs e.g. WS2812B

Screenshot_2019-05-22_00-54-43
Screenshot_2019-05-22_00-55-05
Screenshot_2019-05-22_00-55-58

@CLAassistant
Copy link

CLAassistant commented May 21, 2019

CLA assistant check
All committers have signed the CLA.

@antoniovazquezblanco
Copy link
Collaborator

@Misca1234
Copy link
Collaborator

Misca1234 commented Jun 22, 2019

@dxrpl
Hi

Some standard questions

Is there a foot print push connected to this 3D model (I can not find a matching foot print) ?
Have you made the model yourself?

If you made it yourself, did you use FreeCad, and if so, did you use the stepup macro to export the .step and .wrl files?

@dxrpl
Copy link
Contributor Author

dxrpl commented Jun 23, 2019

Hi,
No, I used footprint from library kicad/modules/LED_SMD.pretty/LED_WS2812B_PLCC4_5.0x5.0mm_P3.2mm.kicad_mod

Yes, I made model by myself according to datasheet https://cdn-shop.adafruit.com/datasheets/WS2812B.pdf

Yes, I did it exactly as you said and I pushed FreeCAD source file to 3D source library.

@Misca1234 Misca1234 merged commit ad2a8c0 into KiCad:master Jun 25, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.3 milestone Jun 26, 2019
@antoniovazquezblanco antoniovazquezblanco removed the Pending reviewer A pull request waiting for a reviewer label Jun 26, 2019
@Misca1234
Copy link
Collaborator

@KiCad/librarians
I need some help here by the librarians

I have no memory of merging this one (It is not review yet), beside, when I fetch and merge the master branch from the kicad repository this push/merge does not appear on my local master?

@evanshultz
Copy link
Collaborator

I don't know what's going on either, but the files shown as merged in this PR are not at https://github.com/KiCad/kicad-packages3D/tree/master/LED_SMD.3dshapes.

Also, I don't see any news about GH being attacked in the past couple days.

Sorry. Not sure what else to tell ya...

@antoniovazquezblanco
Copy link
Collaborator

Also there is usually a revert button near the merge notification but it is not present in this PR.

What is going on?

@Misca1234
Copy link
Collaborator

@dxrpl
It seems something fuzzy have happen

Let us restart but before you make a re push of the 3D model

You have made a 3D model called LED_PLCC4_5.0x5.0mm_P3.2mm
Have you made a foot print push as well ?
I can not see LED_PLCC4_ in kicad-footprints

Have you made this model for a coming foot print or is the idea to use it for existing foot print ?
(usually the foot print have 3D model with the same name)

@Misca1234
Copy link
Collaborator

@dxrpl
I have created the model with scripts, see
#578
#579

(No need to repush the models)

@dxrpl dxrpl deleted the ws2812b branch June 30, 2019 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new package 3D to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants