Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Transistor sorting #42

Merged
merged 2 commits into from
Dec 13, 2017
Merged

Transistor sorting #42

merged 2 commits into from
Dec 13, 2017

Conversation

SchrodingersGat
Copy link
Contributor

The transistor library was too large, and had some parts that were not actually transistors.

This PR sorts transistors into:

  • BJT
  • FET
  • IGBT

And also moves non-transistor parts to where they should go.

Transistor.lib has been deleted.

- BJT
- FET
- IGBT
- Other assorted components (not actually transistors!)
@poeschlr
Copy link
Collaborator

poeschlr commented Dec 8, 2017

Is it on purpose to move transistors into power management?
Yes they can be used for power management but this is not really what i would search in that lib. (I would expect the power management lib to contain the chip that tells the fet to turn on or off.)

Edit:
Maybe transistor_smart or transistor_intelligent would be better names?

@evanshultz
Copy link
Collaborator

@poeschlr Only transistors with supporting circuitry moved into that lib. Discrete transistors are in the 3 libs mentioned above and that all looks fine to me.

There are loads more intelligent switches in the old ir.lib. Do you want to take care of those right now?

@poeschlr
Copy link
Collaborator

poeschlr commented Dec 8, 2017

So you would say that this transistor: https://www.infineon.com/dgdl/ips6011pbf.pdf?fileId=5546d462533600a4015355c3db3d1625
should be in power management?

From the feature list i would say it is the same as all other infineon high side smart switches. (minus spi control which some of them have) Would you move all high side smart switches into power_management?

@evanshultz
Copy link
Collaborator

My comment above only said that discrete transistors were in the libs mentioned above and that transistors with extra stuff were in power_management. I did not state any belief or preference.

It does make sense to me that discrete transistors and these intelligent/smart transistors are separated. The user is free to use a discrete transistor in any way they like, and that doesn't apply to these smart switches. I think that power_management would be for switch controllers, PMICs, current monitors, etc., and my brain would not look for not smart switches there.

Other than perhaps separating high-side and low-side, I can't think of anything better than your suggestions above for new lib names. My gut says there may be an even better lib name with further consideration, though.

@SchrodingersGat
Copy link
Contributor Author

Digikey categories all these under PMIC - Power Distribution.

My feeling was to group these and other power devices (e.g. ideal diode controllers) into a single category to avoid too much splintering of the libs...

@SchrodingersGat
Copy link
Contributor Author

Any further issues preventing merge?

@poeschlr
Copy link
Collaborator

I will merge it for now, but i still think power_management is not the best place to put smart fets. But this can be discussed in a separate issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing symbol in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants