Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Adding TPS51363 #733

Merged
merged 8 commits into from
Oct 14, 2018
Merged

Adding TPS51363 #733

merged 8 commits into from
Oct 14, 2018

Conversation

ki5libs
Copy link
Contributor

@ki5libs ki5libs commented Jul 5, 2018

Adding TPS51363
Datasheet
tps51363
Footprint PR


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@jneiva08
Copy link
Contributor

jneiva08 commented Jul 7, 2018

The VIN, SW and PGND should be stacked (passive and invisible),
The NC could be on edge of square,
The symbol can shrunk a little?

@ki5libs
Copy link
Contributor Author

ki5libs commented Jul 7, 2018

Reworked

@antoniovazquezblanco antoniovazquezblanco added Pending reviewer A pull request waiting for a reviewer Addition Adds new symbols to library labels Oct 5, 2018
@Misca1234
Copy link
Collaborator

Do you think EP, PGND and GND all be stacked ?

You should change the description
from
High-voltage input, synchronous converter with integrated FET
to
High-voltage input, synchronous converter with integrated FET, QFN28

I can not match your foot print filter to a known foot print,
is it missing ?

@Misca1234 Misca1234 added Pending changes User is expected to perform fixes before merging and removed Pending reviewer A pull request waiting for a reviewer labels Oct 13, 2018
@ki5libs
Copy link
Contributor Author

ki5libs commented Oct 13, 2018

@Misca1234
I've added default footprint, changed footprint filter and description.

According to KLC S4.3 stacked pins should have the same name. Pins EP, PGND and GND have different names and separate description in the datasheet (though they should be connected together on the schematic) so I think it should not be stacked. It's common practice isn't it?

@Misca1234
Copy link
Collaborator

High-voltage input, synchronous converter with integrated FET, QFN28
Sorry, it should be QFN-28

stacked pins should have the same name. Pins EP, PGND and GND have different names and separate > description in the datasheet (though they should be connected together on the schematic)

In case of stacking, they got all the same name even if they 'are an EP'

It was a suggestion to stack them, but you think it is an bad idea?

@ki5libs
Copy link
Contributor Author

ki5libs commented Oct 14, 2018

@Misca1234
I've fixed the package type in description.

I've looked through different symbols in the library and found that EP is often made as a separate pin despite to mandatory connection to GND. As I already said datasheet separates these pins in the table PIN FUNCTIONS giving them different names. I'm not sure that they internally connected together (it doesn't show on block diagram). We could change pin names and stack them, but it would be a small falsification of datasheet information. Is there some clear rule or criteria when we can do this? I couldn't find it in the KLC.
func

I offer leave it as it is. I suppose that connection of these pins could be left up to schematic designer. Please, correct me if I make a mistake.

@Misca1234
Copy link
Collaborator

Then we all good

@Misca1234 Misca1234 merged commit 21b9b3f into KiCad:master Oct 14, 2018
@myfreescalewebpage myfreescalewebpage removed the Pending changes User is expected to perform fixes before merging label Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants