Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to CommonJS export for module: 'node16' #21

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Switch to CommonJS export for module: 'node16' #21

merged 3 commits into from
Feb 1, 2023

Conversation

karlhorky
Copy link
Contributor

@karlhorky karlhorky mentioned this pull request Jan 31, 2023
Merged
andrewbranch
andrewbranch suggested changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also remove the declare module wrapper as you suggested, which means the declare modifier will move to before function.

index.d.ts Outdated Show resolved Hide resolved
@karlhorky
Copy link
Contributor Author

Done, removed the ambient declaration, thanks for the guidance!

@Kikobeats
Copy link
Owner

Thanks!

@Kikobeats Kikobeats merged commit 66c0ee7 into Kikobeats:master Feb 1, 2023
@karlhorky karlhorky deleted the patch-1 branch February 1, 2023 09:33
@karlhorky
Copy link
Contributor Author

Glad to help, thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karlhorky @Kikobeats @andrewbranch