feat: Implement Live Preview #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on suggestion by @sebaxakerhtc * Add live_preview channel setting default to true and trigger life preview lifecycle based on this setting * Don't see much of a use-case for per-draw toggle so keeping at channel level * Rename global setting `preview_update_interval` to `live_preview_update_interval` to normalize setting wording
Closed
|
Thank y'all for your support and work 💖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #234 -- it is functionally the same work @sebaxakerhtc and I already did but has been rebased on top of 1b17f17 and has all of the minor/cleanup commits squashed into major changes. Additional changes not in #234:
live_previewper-channel setting