Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of the async version #41

Merged
merged 10 commits into from
Sep 19, 2014
Merged

Initial commit of the async version #41

merged 10 commits into from
Sep 19, 2014

Conversation

KimiNewt
Copy link
Owner

Not fully working yet. Some features missing, not tested.
A lot of things were changed, mainly the threads and generators were
changed to coroutines, but the old interface was kept to be backwards
compatible.

Not fully working yet. Some features missing, not tested.
A lot of things were changed, mainly the threads and generators were
changed to coroutines, but the old interface was kept to be backwards
compatible.
@KimiNewt
Copy link
Owner Author

Currently only requires further testing.
There is also a problem where the stderr is printed to stdout despite being seemingly redirected to os.devnull. This is similar to the problem we had in #26
@bbayles looking at the issue, you seemed to have an async version already (which I seem to have missed, doh). It's no longer up. Did you solve the stderr issue somehow?

Changed fixture + repr fix in FileCapture.
+ psml reading fix according to tests
@bbayles
Copy link
Collaborator

bbayles commented Sep 13, 2014

I don't think I had a problem with the version of subprocess I was using (Py3k+) - maybe try with subprocess32 on Py2.7?

Also look at the -Q option in TShark, perhaps.

@KimiNewt
Copy link
Owner Author

Trollius already uses its own subprocess version. I'll check some other things out and otherwise will just use -Q as you suggested.

I think that while the code may be difficult to understand for someone who hasn't done any async programming, it works out rather well while working both asyncly and syncly depending on the situation-- and still allow interactivity.

Conflicts:
	src/pyshark/__init__.py
	src/pyshark/capture/capture.py
	src/pyshark/capture/file_capture.py
	src/pyshark/capture/live_capture.py
decryption support
KimiNewt added a commit that referenced this pull request Sep 19, 2014
Commit of the async version
@KimiNewt KimiNewt merged commit 7d83a90 into master Sep 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants