Fix the bug that the default configs of slice/map are not overridden #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t value Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
added 2 commits
April 3, 2023 16:47
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
NeJan2020
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set
zeroFields=truewhen usingviper.Unmarshalto override the default configs of slice/map.Motivation and Context
Every component has a default configuration when registering to the factory. When unmarshalling the configuration file to the struct, the slices/maps in the configuration and the default one are merged which is not what we expected. This PR adds the option
zeroFields=truetoviper.Unmarshalfor overriding the default configs of slice/map.How Has This Been Tested?