Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2: Added AC calculator #47

Merged
merged 1 commit into from
Nov 23, 2019
Merged

Fix #2: Added AC calculator #47

merged 1 commit into from
Nov 23, 2019

Conversation

Cadesh
Copy link
Contributor

@Cadesh Cadesh commented Nov 17, 2019

Description of pull request

  • Added a Function to calculate AC, the function considers the base AC and add modifiers according to armor max DEX. If no armor, the function checks the profession to add profession specific bonuses.
  • I created some tests but did not uploaded them, if you like I can add JEST to the project.
  • There is one item missing in the calculation, the use of shields.

Resolves #2

Has it been tested?

  • [ X ] Yes
  • No
  • Testing not needed

@KingFruit85
Copy link
Owner

Hey @Cadesh looks good to me! While I was checking it I uncovered a bug with how the ability score modifiers are calculated so doubly useful :)

I don't know much about JEST or unit testing in general and would love to learn some so happy for you to implement if you recommend doing so.

Happy for you to merge 👍

@Cadesh
Copy link
Contributor Author

Cadesh commented Nov 23, 2019

@KingFruit85 I have no write access to the repo, if you are happy with the PR please merge it to main.

I am going to create a Issue to add Travis and JEST for the Continuous Integration, then I will send a new PR for you to check.

@KingFruit85 KingFruit85 merged commit f8dc1e5 into KingFruit85:master Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADD] Calculate AC
2 participants