Skip to content
This repository has been archived by the owner on Aug 5, 2024. It is now read-only.

Safety check with collections created before plugin activation (ref #20) #40

Merged
merged 5 commits into from
May 26, 2017
Merged

Safety check with collections created before plugin activation (ref #20) #40

merged 5 commits into from
May 26, 2017

Conversation

leplatrem
Copy link
Contributor

Ref #20

  • Safety check around index existance

@leplatrem leplatrem requested a review from Natim May 26, 2017 10:00
Natim
Natim suggested changes May 26, 2017
View reviewed changes
kinto_elasticsearch/views.py
@@ -33,17 +33,27 @@ def search_view(request, **kwargs):
indexer = request.registry.indexer
try:
results = indexer.search(bucket_id, collection_id, **kwargs)

except elasticsearch.NotFoundError as e:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a test for this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did ctrl+x instead of ctrl+c when testing record creation :)

@leplatrem leplatrem merged commit a585ab8 into master May 26, 2017
@leplatrem leplatrem deleted the 20-index-existing-records branch May 26, 2017 10:14
@leplatrem leplatrem mentioned this pull request May 26, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Natim Natim Natim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leplatrem @Natim