Delete on plural endpoints

[paullaffitte]

It implements deleteRecords, deleteCollections and deleteBuckets, with the same filtering as listRecords. #95

[leplatrem]

The code looks good :)

However we can't merge without associated tests for these new features

[leplatrem]

@paullaffitte do you need any help? Let us know 🙏 !

[paullaffitte]

@leplatrem Sorry I was on vacation, I think it's okay, maybe I'll need help for the tests but I'll let you know. I'll try to finish it this week-end.

[paullaffitte]

I'm done with writing tests, but I can't seems to find how to properly run the integration tests.
npm run test gives me: "Uncaught Error: spawn pserve ENOENT"
and TEST_KINTO_SERVER=localhost:8888/v1 npm run test: "TypeError: Cannot read property 'flush' of undefined"

[dstaley]

@paullaffitte You'll need to be in a python venv to run the integration tests. (Alternatively you can pip install kinto kinto-attachment, but using a venv is highly recommended)

The following should work with Python 3 on Linux:

$ python3 -m venv .venv
$ source .venv/bin/activate
(.venv) $ pip install kinto kinto-attachment
$ npm run test

[paullaffitte]

That's very nice that there is some automated tests now. If they were there at the time I started the PR, it would be already merge maybe haha.

Anyway, sorry about the time I took to complete it, I was overwhelmed by work/studies/personal projects and I kind of forgot about this PR. I rebased my branch today and updated what should be updated. I also have tested it locally but I guess that the automated tests will show us if my work is good or not.

[leplatrem]

Excellent! Thanks for coming back to this!

I reported a few nits to address and then we're good to merge!

That's very nice that there is some automated tests now. If they were there at the time I started the PR, it would be already merge maybe haha.

What do you mean? This repo had tests since its first commit :) https://github.com/Kinto/kinto-http.js/tree/87c681c82a

[paullaffitte]

That's very nice that there is some automated tests now. If they were there at the time I started the PR, it would be already merge maybe haha.

What do you mean? This repo had tests since its first commit :) https://github.com/Kinto/kinto-http.js/tree/87c681c82a

I maybe just didn't remember about it, I was pretty sure that I had to run the tests locally.

I will do the requested changes during this week.

[paullaffitte]

Looks like the tests on firefox failed for session issue rather than because of my code (that I didn't change since last successful pipeline anyway, so it would makes sense).

[dstaley]

All good now :) I'll review this over the next few days. Thanks again for contributing!

[dstaley]

@paullaffitte Thank you so much for contributing, and hanging in there while we reviewed this. I really appreciate your patience and your effort in getting this ready to merge! 🎉 🎉