Add additional handling of symbolic links #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use std::filesystem in this place
Add tests Windows Update README.md
KitRifty
force-pushed
the
sym-links
branch
3 times, most recently
from
e2a70fe
to
66f1ea9
Compare
KitRifty
force-pushed
the
sym-links
branch
2 times, most recently
from
a769ccc
to
be0afb4
Compare
KitRifty
force-pushed
the
sym-links
branch
2 times, most recently
from
cc0e58c
to
3e4b17c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some breaking changes.
Some special handling is required when it comes to directory symbolic links. On Windows,
ReadDirectoryChangesExWwill not read the subtree of a directory symbolic link despitebWatchSubtreeset totrue. On Linux, the current build didn't take symbolic links into account.Now, the watcher can watch directory symbolic links.
Changes
FileSystemWatcherwith a relative path that leads to outside of the game directory will now throw an error.FileSystemWatcher.GetPath()will no longer be guaranteed to have a trailing separator.FileSystemWatcher.WatchDirectoryLinks, which toggles whether to watch subdirectory symbolic links. By default, this is set totrue.FileSystemWatcher.RetryIntervalis now deprecated and does nothing.