Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent KCL sessions #699

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Persistent KCL sessions #699

merged 1 commit into from
Jun 19, 2024

Conversation

adamchalmers
Copy link
Contributor

Two changes:

  • A new zoo start-session command will connect to the KittyCAD engine and start a modeling session.
  • The zoo kcl snapshot command accepts an optional --session address. If given, it reuses the modeling session instead of establishing a new connection.

This is still experimental, once it's working properly we'll add support for the other zoo kcl subcommands e.g. zoo kcl export.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 78.06%. Comparing base (5df4312) to head (1d80888).

Files Patch % Lines
src/cmd_start_session.rs 8.33% 11 Missing ⚠️
src/cmd_kcl.rs 87.23% 6 Missing ⚠️
src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
- Coverage   78.19%   78.06%   -0.13%     
==========================================
  Files          35       36       +1     
  Lines        7613     7651      +38     
==========================================
+ Hits         5953     5973      +20     
- Misses       1660     1678      +18     
Flag Coverage Δ
unittests 78.06% <70.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- A new `zoo start-session` command will connect to the KittyCAD engine and start a modeling session.
- The `zoo kcl snapshot` command accepts an optional `--session` address. If given, it reuses the modeling session instead of establishing a new connection.

This is still experimental, once it's working properly we'll add support for the other `zoo kcl` subcommands e.g. `zoo kcl export`.
@adamchalmers adamchalmers merged commit 7523ce9 into main Jun 19, 2024
7 of 8 checks passed
@adamchalmers adamchalmers deleted the achalmers/test-server branch June 19, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant