Debugger: Allow comments on instructions #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #205 The input JSON has been modified. Previously it accepted a Vec<Instruction>, now that is just one field of a JSON object. The other field is a map from instruction indices to string comments. These comments show up in the debugger as events at the start of that instruction.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
=======================================
Coverage ? 49.33%
=======================================
Files ? 47
Lines ? 5007
Branches ? 0
=======================================
Hits ? 2470
Misses ? 2537
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #205
The input JSON has been modified. Previously it accepted a Vec, now that is just one field of a JSON object.
The other field is a map from instruction indices to string comments. These comments show up in the debugger as events at the start of that instruction.
Grackle will be updated to set these comments, to make it easier to read Grackle traces in this debugger.