Require hyphens on UUIDv4 & add ErrorCode::AuthToken #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
=======================================
Coverage ? 55.05%
=======================================
Files ? 51
Lines ? 5854
Branches ? 0
=======================================
Hits ? 3223
Misses ? 2631
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adamchalmers
approved these changes
May 15, 2024
|
I had to add a custom deserializer to invoke the new method in places that don't invoke it directly, since many places just use serde to access this value. @adamchalmers could I get a quick sanity peek and re-approval? Thanks :) |
|
This is now growing because it's just easier to get these small changes in... |
lf94
force-pushed
the
lf94/require-hyphens
branch
from
fadf4a6
to
3f575f7
Compare
lf94
changed the title
|
pushed to crates and tagged |
adamchalmers
added a commit
that referenced
this pull request
May 16, 2024
We transmit modeling cmd IDs as strings (when serialized to JSON) and as bytes (when serialized to BSON). However a [recent PR](#333) started using a custom deserializer for modeling cmd IDs, which only implemented deser for strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.