AST function nodes no longer have stdlib function members #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
IMO the AST should not need an actual pointer to a stdlib function -- that is a completely separate concern from the AST. Instead, the AST nodes can just store function names, and the executor will have a stdlib which it can look up those names in.
adamchalmers
force-pushed
the
achalmers/no-stdlib-in-parser
branch
from
76a3df5
to
81738e9
Compare
adamchalmers
force-pushed
the
achalmers/no-stdlib-in-parser
branch
from
ec11e8b
to
d3bd64a
Compare
Irev-Dev
approved these changes
Nov 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO the AST should not need an actual pointer to a stdlib function -- that is a completely separate concern from the AST. The AST should just need to know which function to execute. The executor should know how to execute them.
So I suggest the AST nodes can just store function names, and the executor will have a stdlib which it can look up those names in.
This will really help simplify #922 -- if there's a good reason to keep the stdlib functions referenced from AST nodes, I can find another solution. But if it's just a decision that made sense at the time, then I think we should separate them.